Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use reduction to compute min and max particle distances in NeighborParticles test. #3212

Merged
merged 9 commits into from
Jul 22, 2024
Merged

Use reduction to compute min and max particle distances in NeighborParticles test. #3212

merged 9 commits into from
Jul 22, 2024

Conversation

atmyers
Copy link
Member

@atmyers atmyers commented Mar 22, 2023

This replaces a much slower atomics-based check.

Summary

Additional background

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@asalmgren asalmgren self-requested a review July 22, 2024 16:45
atmyers and others added 2 commits July 22, 2024 13:47
@atmyers @WeiqunZhang
Update Tests/Particles/NeighborParticles/MDParticleContainer.cpp
d5cac85 
Co-authored-by: Weiqun Zhang <WeiqunZhang@lbl.gov>
@atmyers @WeiqunZhang
Update Tests/Particles/NeighborParticles/MDParticleContainer.cpp
75627c7 
Co-authored-by: Weiqun Zhang <WeiqunZhang@lbl.gov>
@atmyers atmyers enabled auto-merge (squash) July 22, 2024 21:05
@atmyers atmyers merged commit 3e4a2d5 into AMReX-Codes:development Jul 22, 2024
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WeiqunZhang WeiqunZhang WeiqunZhang approved these changes

@asalmgren asalmgren Awaiting requested review from asalmgren

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atmyers @WeiqunZhang